Skip to content

docs(dialog): add note about setting initial focus #9110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2018
Merged

docs(dialog): add note about setting initial focus #9110

merged 1 commit into from
Jan 2, 2018

Conversation

crisbeto
Copy link
Member

Adds a note to the dialog docs about setting the initial focus.

Relates to #9107.

@crisbeto
docs(dialog): add note about setting initial focus
a309e2e 
Adds a note to the dialog docs about setting the initial focus.

Relates to angular#9107.
@crisbeto crisbeto requested a review from jelbourn as a code owner December 23, 2017 21:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 23, 2017
jelbourn
jelbourn approved these changes Jan 2, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 2, 2018
@jelbourn jelbourn merged commit 77b45f5 into angular:master Jan 2, 2018
@jelbourn jelbourn added the docs This issue is related to documentation label Jan 2, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot